-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable ng_package test temporarily #22933
Conversation
Accept the new golden file: | ||
bazel run ${process.env['BAZEL_TARGET']}.accept | ||
`); | ||
|
||
Diff: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you move the diff first, so the easiest thing to see at the end of the output is how to accept the change?
@@ -49,11 +50,19 @@ if (require.main === module) { | |||
if (actual === expected) { | |||
return; | |||
} | |||
|
|||
let patch = createPatch(goldenFile, expected, actual, 'Golden file', 'Generated file', {context: 5}); | |||
const endOfHeader = patch.indexOf('\n', patch.indexOf('\n') + 1) + 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to comment why we do this - does the diff look bad otherwise (I know you're copy-pasting but don't want to blindly cargo-cult)
@@ -48,6 +48,7 @@ jasmine_node_test( | |||
"example_package.golden", | |||
"//packages/bazel/test/ng_package/example:npm_package", | |||
], | |||
tags = ["manual"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a TODO here for me
You can preview ac822f8 at https://pr22933-ac822f8.ngbuilds.io/. |
You can preview 6a5a178 at https://pr22933-6a5a178.ngbuilds.io/. |
merge-assistance: don't believe the bot. This PR is green. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Because it fails CircleCI with #22654
Also added a diff output to ease debugging.
(Part of) the error I observe locally is:
/ref #22814